-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add dimming to vdisk page (nodes) and pdisk page (vdisks) #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dimming to vdisk page (nodes) and pdisk page (vdisks) #1397
Conversation
| <StorageWrapper | ||
| groupId={GroupID} | ||
| nodeId={nodeId} | ||
| pDiskId={pDiskId ?? undefined} | ||
| vDiskSlotId={vDiskSlotId ?? undefined} | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use PaginatedTable on entities pages (VDisk, PDisk, StorageGroup), in most cases you know or at least can assume number of entities. Please pass it to PaginatedTable as initialEntitiesCount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came up only with the most obvious idea of predicting number of entities
2d95afe#diff-523848b17ed76710cf4ba5acac5ac6d651800670770f9199339a88f94d8a4714R29
If you meant something different - give me a clue =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I meant something like this. For some pages we can be sure, that there would be only 1 row in table, or some value in range
NodePage - many groups (initial count undefined), 1 node
GroupPage - 1 group, usually up to 9 nodes
PDiskPage - up to 24 groups (but usually less, 9-10 initial value looks fine), 1 node
VDiskPage - 1 group, 1 node
And it would be better to implement it with some helper functions:
function getStorageNodesInitialEntitiesCount (viewContext){
if(valueIsDefined(nodeId)){
return 1
}
// other conditions
return undefined
}
Closes #1373
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔽
Current: 79.31 MB | Main: 79.31 MB
Diff: 0.01 MB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information