Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Oct 3, 2024

Closes #1373

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
124 121 0 3 0

Bundle Size: 🔽

Current: 79.31 MB | Main: 79.31 MB
Diff: 0.01 MB (-0.01%)

✅ Bundle size decreased.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Comment on lines +181 to +186
<StorageWrapper
groupId={GroupID}
nodeId={nodeId}
pDiskId={pDiskId ?? undefined}
vDiskSlotId={vDiskSlotId ?? undefined}
/>
Copy link
Member

@artemmufazalov artemmufazalov Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use PaginatedTable on entities pages (VDisk, PDisk, StorageGroup), in most cases you know or at least can assume number of entities. Please pass it to PaginatedTable as initialEntitiesCount

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came up only with the most obvious idea of predicting number of entities

2d95afe#diff-523848b17ed76710cf4ba5acac5ac6d651800670770f9199339a88f94d8a4714R29

If you meant something different - give me a clue =)

Copy link
Member

@artemmufazalov artemmufazalov Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant something like this. For some pages we can be sure, that there would be only 1 row in table, or some value in range

NodePage - many groups (initial count undefined), 1 node
GroupPage - 1 group, usually up to 9 nodes
PDiskPage - up to 24 groups (but usually less, 9-10 initial value looks fine), 1 node
VDiskPage - 1 group, 1 node

And it would be better to implement it with some helper functions:

function getStorageNodesInitialEntitiesCount (viewContext){
  if(valueIsDefined(nodeId)){
    return 1
  }
  // other conditions

  return undefined
}

@astandrik astandrik added this pull request to the merge queue Oct 5, 2024
Merged via the queue into main with commit deb2a88 Oct 5, 2024
6 checks passed
@astandrik astandrik deleted the astandrik.add-dimming-to-vdisk-pdisk-pages-1373 branch October 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add dimming to vdisk page (nodes) and pdisk page (vdisks)

3 participants